mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

misc/dashboard/codereview: interpret zero reviewers as the CL being closed. 

This is the state when the CL has been submitted by someone other than
the CL author, but before the CL author has synched their client.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6458044
This commit is contained in:
David Symonds 2012-07-30 13:51:21 +10:00
parent dd166b9437
commit 482ceeda6d
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
misc/dashboard/codereview/dashboard/cl.go
View File

@ -294,12 +294,13 @@ func updateCL(c appengine.Context, n string) error {
} }
var apiResp struct { var apiResp struct {
Description string `json:"description"` Description string `json:"description"`
Created string `json:"created"` Reviewers []string `json:"reviewers"`
OwnerEmail string `json:"owner_email"` Created string `json:"created"`
Modified string `json:"modified"` OwnerEmail string `json:"owner_email"`
Closed bool `json:"closed"` Modified string `json:"modified"`
Subject string `json:"subject"` Closed bool `json:"closed"`
Subject string `json:"subject"`
Messages []struct { Messages []struct {
Text string `json:"text"` Text string `json:"text"`
Sender string `json:"sender"` Sender string `json:"sender"`
@ -334,6 +335,13 @@ func updateCL(c appengine.Context, n string) error {
if i := strings.Index(cl.FirstLine, "\n"); i >= 0 { if i := strings.Index(cl.FirstLine, "\n"); i >= 0 {
cl.FirstLine = cl.FirstLine[:i] cl.FirstLine = cl.FirstLine[:i]
} }
// Treat zero reviewers as a signal that the CL is completed.
// This could be after the CL has been submitted, but before the CL author has synced,
// but it could also be a CL manually edited to remove reviewers.
if len(apiResp.Reviewers) == 0 {
cl.Closed = true
}
lgtm := make(map[string]bool) lgtm := make(map[string]bool)
notLGTM := make(map[string]bool) notLGTM := make(map[string]bool)
rcpt := make(map[string]bool) rcpt := make(map[string]bool)