mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

reflect: define MyBuffer more locally in TestImplicitMapConversion 

There are no strange messages anymore, so define type MyBuffer in the
block where it is used.

Change-Id: Ic65b15dc76a40f6f734d9ac2116338502fbb66fd
Reviewed-on: https://go-review.googlesource.com/107735
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Tobias Klauser 2018-04-18 11:52:39 +02:00 committed by Tobias Klauser
parent 4869ec00e8
commit 47435b1da1
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/reflect/set_test.go
View File

@ -14,8 +14,6 @@ import (
"unsafe"
)
type MyBuffer bytes.Buffer
func TestImplicitMapConversion(t *testing.T) {
// Test implicit conversions in MapIndex and SetMapIndex.
{
@ -102,10 +100,7 @@ func TestImplicitMapConversion(t *testing.T) {
}
{
// convert identical underlying types
// TODO(rsc): Should be able to define MyBuffer here.
// 6l prints very strange messages about .this.Bytes etc
// when we do that though, so MyBuffer is defined
// at top level.
type MyBuffer bytes.Buffer
m := make(map[*MyBuffer]*bytes.Buffer)
mv := ValueOf(m)
b1 := new(MyBuffer)