mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

misc/ios: fixup review comments from CL 255257 

Change-Id: I247fc9e0e26e706e6af07367f953eaa1b7e544c1
Reviewed-on: https://go-review.googlesource.com/c/go/+/259577
Trust: Elias Naur <mail@eliasnaur.com>
Run-TryBot: Elias Naur <mail@eliasnaur.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
Elias Naur 2020-10-05 17:51:54 +02:00
parent 059ca6185c
commit 39d562ecea
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
misc/ios/detect.go
View File

@ -6,7 +6,7 @@
// detect attempts to autodetect the correct // detect attempts to autodetect the correct
// values of the environment variables // values of the environment variables
// used by go_io_exec. // used by go_ios_exec.
// detect shells out to ideviceinfo, a third party program that can // detect shells out to ideviceinfo, a third party program that can
// be obtained by following the instructions at // be obtained by following the instructions at
// https://github.com/libimobiledevice/libimobiledevice. // https://github.com/libimobiledevice/libimobiledevice.

8
misc/ios/go_ios_exec.go
View File

@ -59,12 +59,12 @@ var lock *os.File
func main() { func main() {
log.SetFlags(0) log.SetFlags(0)
log.SetPrefix("go_darwin_arm_exec: ") log.SetPrefix("go_ios_exec: ")
if debug { if debug {
log.Println(strings.Join(os.Args, " ")) log.Println(strings.Join(os.Args, " "))
} }
if len(os.Args) < 2 { if len(os.Args) < 2 {
log.Fatal("usage: go_darwin_arm_exec a.out") log.Fatal("usage: go_ios_exec a.out")
} }
// For compatibility with the old builders, use a fallback bundle ID // For compatibility with the old builders, use a fallback bundle ID
@ -79,7 +79,7 @@ func main() {
func runMain() (int, error) { func runMain() (int, error) {
var err error var err error
tmpdir, err = ioutil.TempDir("", "go_darwin_arm_exec_") tmpdir, err = ioutil.TempDir("", "go_ios_exec_")
if err != nil { if err != nil {
return 1, err return 1, err
} }
@ -100,7 +100,7 @@ func runMain() (int, error) {
// //
// The lock file is never deleted, to avoid concurrent locks on distinct // The lock file is never deleted, to avoid concurrent locks on distinct
// files with the same path. // files with the same path.
lockName := filepath.Join(os.TempDir(), "go_darwin_arm_exec-"+deviceID+".lock") lockName := filepath.Join(os.TempDir(), "go_ios_exec-"+deviceID+".lock")
lock, err = os.OpenFile(lockName, os.O_CREATE|os.O_RDONLY, 0666) lock, err = os.OpenFile(lockName, os.O_CREATE|os.O_RDONLY, 0666)
if err != nil { if err != nil {
return 1, err return 1, err