From 39095c1d176c032bd8915f1173c0c77f502f579d Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Thu, 16 Jan 2020 18:34:52 -0500 Subject: [PATCH] gopls/internal/hooks: ignore a duplicate analysis from staticcheck Hardcoded for now. Will need a better approach if more of these come up. Fixes golang/go#34494 Change-Id: Id442d68fa16d81e747ad5ec951fb6b80fdb65f94 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215118 Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot Reviewed-by: Heschi Kreinick --- gopls/internal/hooks/analysis.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gopls/internal/hooks/analysis.go b/gopls/internal/hooks/analysis.go index 0549b4f19d..629bdc8669 100644 --- a/gopls/internal/hooks/analysis.go +++ b/gopls/internal/hooks/analysis.go @@ -17,6 +17,10 @@ func updateAnalyzers(options *source.Options) { options.Analyzers[a.Name] = a } for _, a := range staticcheck.Analyzers { + // This check conflicts with the vet printf check (golang/go#34494). + if a.Name == "SA5009" { + continue + } options.Analyzers[a.Name] = a } for _, a := range stylecheck.Analyzers {