mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

runtime: log profile when mutex profile test fails 

For #70602

Change-Id: I3f723ebc17ef690d5be7f4f948c9dd1f890196fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/658095
Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This commit is contained in:
Rhys Hiltner 2025-03-14 13:47:54 -07:00 committed by Gopher Robot
parent 21417518a9
commit 35139d6e45
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/runtime/metrics_test.go
View File

@ -1020,8 +1020,8 @@ func TestRuntimeLockMetricsAndProfile(t *testing.T) {
return metricGrowth, profileGrowth, p return metricGrowth, profileGrowth, p
} }
testcase := func(strictTiming bool, acceptStacks [][]string, workers int, fn func() bool) func(t *testing.T) (metricGrowth, profileGrowth float64, n, value int64) { testcase := func(strictTiming bool, acceptStacks [][]string, workers int, fn func() bool) func(t *testing.T) (metricGrowth, profileGrowth float64, n, value int64, explain func()) {
return func(t *testing.T) (metricGrowth, profileGrowth float64, n, value int64) { return func(t *testing.T) (metricGrowth, profileGrowth float64, n, value int64, explain func()) {
metricGrowth, profileGrowth, p := measureDelta(t, func() { metricGrowth, profileGrowth, p := measureDelta(t, func() {
var started, stopped sync.WaitGroup var started, stopped sync.WaitGroup
started.Add(workers) started.Add(workers)
@ -1113,7 +1113,9 @@ func TestRuntimeLockMetricsAndProfile(t *testing.T) {
} }
} }
return metricGrowth, profileGrowth, n, value return metricGrowth, profileGrowth, n, value, func() {
t.Logf("profile:\n%s", p)
}
} }
} }
@ -1173,7 +1175,12 @@ func TestRuntimeLockMetricsAndProfile(t *testing.T) {
defer runtime.SetMutexProfileFraction(old) defer runtime.SetMutexProfileFraction(old)
needContention.Store(int64(len(mus) - 1)) needContention.Store(int64(len(mus) - 1))
metricGrowth, profileGrowth, n, _ := testcase(true, stks, workers, fn)(t) metricGrowth, profileGrowth, n, _, explain := testcase(true, stks, workers, fn)(t)
defer func() {
if t.Failed() {
explain()
}
}()
t.Run("metric", func(t *testing.T) { t.Run("metric", func(t *testing.T) {
// The runtime/metrics view may be sampled at 1 per // The runtime/metrics view may be sampled at 1 per
@ -1208,7 +1215,12 @@ func TestRuntimeLockMetricsAndProfile(t *testing.T) {
defer runtime.SetMutexProfileFraction(old) defer runtime.SetMutexProfileFraction(old)
needContention.Store(int64(len(mus) - 1)) needContention.Store(int64(len(mus) - 1))
metricGrowth, profileGrowth, n, _ := testcase(true, stks, workers, fn)(t) metricGrowth, profileGrowth, n, _, explain := testcase(true, stks, workers, fn)(t)
defer func() {
if t.Failed() {
explain()
}
}()
// With 100 trials and profile fraction of 2, we expect to capture // With 100 trials and profile fraction of 2, we expect to capture
// 50 samples. Allow the test to pass if we get at least 20 samples; // 50 samples. Allow the test to pass if we get at least 20 samples;