From 2583041a9ded1b6efc6612d7d0743a42a00dde99 Mon Sep 17 00:00:00 2001 From: Rob Findley Date: Fri, 9 Jul 2021 10:43:12 -0400 Subject: [PATCH] go/packages: fix data race in TestCgoNoSyntax CL 332350 introduced a race to exported.Config.Mode when it parallelized this test. Revert the call to t.Parallel. Change-Id: Ifd4b6c4037ee30e8b3f55dc69d4f9f3f09a89185 Reviewed-on: https://go-review.googlesource.com/c/tools/+/333509 Trust: Robert Findley Run-TryBot: Robert Findley Reviewed-by: Bryan C. Mills TryBot-Result: Go Bot --- go/packages/packages_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index afc0a80b58..61cd384712 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -1905,8 +1905,6 @@ func testCgoNoSyntax(t *testing.T, exporter packagestest.Exporter) { for _, mode := range modes { mode := mode t.Run(fmt.Sprint(mode), func(t *testing.T) { - t.Parallel() - exported.Config.Mode = mode pkgs, err := packages.Load(exported.Config, "golang.org/fake/c") if err != nil {