From 22a5a52fcb7ee25e5005bb9a014ef8a94d52fb32 Mon Sep 17 00:00:00 2001 From: Dana Burkart Date: Fri, 7 Jun 2024 20:22:57 -0700 Subject: [PATCH] Address feedback to add a comment instead of changing constants. --- src/time/format.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/time/format.go b/src/time/format.go index 4ac264b4aa..6488ec8aba 100644 --- a/src/time/format.go +++ b/src/time/format.go @@ -32,6 +32,10 @@ import ( // only to local times. Applying them to UTC times will use "UTC" as the // time zone abbreviation, while strictly speaking those RFCs require the // use of "GMT" in that case. +// When using the [RFC1123] or [RFC1123Z] formats for parsing, note that these +// formats define a leading zero for the day-in-month portion, which is not +// strictly allowed by RFC 1123. This will result in an error when parsing +// date strings that occur in the first 9 days of a given month. // In general [RFC1123Z] should be used instead of [RFC1123] for servers // that insist on that format, and [RFC3339] should be preferred for new protocols. // [RFC3339], [RFC822], [RFC822Z], [RFC1123], and [RFC1123Z] are useful for formatting; @@ -110,8 +114,8 @@ const ( RFC822 = "02 Jan 06 15:04 MST" RFC822Z = "02 Jan 06 15:04 -0700" // RFC822 with numeric zone RFC850 = "Monday, 02-Jan-06 15:04:05 MST" - RFC1123 = "Mon, 2 Jan 2006 15:04:05 MST" - RFC1123Z = "Mon, 2 Jan 2006 15:04:05 -0700" // RFC1123 with numeric zone + RFC1123 = "Mon, 02 Jan 2006 15:04:05 MST" + RFC1123Z = "Mon, 02 Jan 2006 15:04:05 -0700" // RFC1123 with numeric zone RFC3339 = "2006-01-02T15:04:05Z07:00" RFC3339Nano = "2006-01-02T15:04:05.999999999Z07:00" Kitchen = "3:04PM"