mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmd/compile: change the multiple (gossa)hash separator from ; to / 

Semicolon has bad copy-paste ergonomics; it requires quoting.
Slash is okay, and won't be a separator ever in debug strings
because it is already used in e.g. ssa/phase/debug=etc.

Change-Id: I493360e9282666eea1a342971a77df2ebd6c92ad
Reviewed-on: https://go-review.googlesource.com/c/go/+/447975
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
David Chase 2022-11-04 11:23:12 -04:00
parent ada9385a5f
commit 1bcfdc777a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/base/hashdebug.go
View File

@ -140,7 +140,7 @@ func NewHashDebug(ev, s string, file writeSyncer) *HashDebug {
hd.no = true
return hd
}
ss := strings.Split(s, ";")
ss := strings.Split(s, "/")
hd.matches = append(hd.matches, toHashAndMask(ss[0], ev))
// hash searches may use additional EVs with 0, 1, 2, ... suffixes.
for i := 1; i < len(ss); i++ {

2
src/cmd/compile/internal/base/hashdebug_test.go
View File

@ -130,7 +130,7 @@ func TestHashNoMatch(t *testing.T) {
func TestHashSecondMatch(t *testing.T) {
ws := new(bufferWithSync)
hd := NewHashDebug("GOSSAHASH", "001100;0011", ws)
hd := NewHashDebug("GOSSAHASH", "001100/0011", ws)
check := hd.DebugHashMatch("bar")
msg := ws.String()