mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

go/pointer: skip TestInput on 32-bit platforms 

This test was already memory-hungry to begin with, and apparently the
switch to go/packages in CL 356513 pushed it over the edge of the
32-bit address space (at least with the default GOGC setting). Rather
than trying to precisely tune it to skim under the 32-bit limit,
let's just skip the test on platforms with insufficient address space.

Updates golang/go#14113
Updates golang/go#48547

Change-Id: Iab99e9ce70a98034194d7c7ad7df7a545ac95ef3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/360837
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Bryan C. Mills 2021-11-02 15:37:35 -04:00
parent f6440c8244
commit 182bbdcec9
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
go/pointer/pointer_test.go
View File

@ -26,6 +26,7 @@ import (
"strconv"
"strings"
"testing"
"unsafe"
"golang.org/x/tools/go/callgraph"
"golang.org/x/tools/go/packages"
@ -553,6 +554,9 @@ func TestInput(t *testing.T) {
if testing.Short() {
t.Skip("skipping in short mode; this test requires tons of memory; https://golang.org/issue/14113")
}
if unsafe.Sizeof(unsafe.Pointer(nil)) <= 4 {
t.Skip("skipping memory-intensive test on platform with small address space; https://golang.org/issue/14113")
}
ok := true
wd, err := os.Getwd()