mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

runtime: remove guard against uninitialized forcegc.g 

The race was in the old C code.
The new Go code does not have the race
and does not need the check.

LGTM=bradfitz, dvyukov
R=golang-codereviews, bradfitz, dvyukov
CC=golang-codereviews, rlh
https://golang.org/cl/140180043
This commit is contained in:
Russ Cox 2014-09-03 12:48:32 -04:00
parent 467a6d28be
commit 176c44699b
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/pkg/runtime/proc.c
View File

@ -2955,12 +2955,9 @@ sysmon(void)
lastgc = runtime·atomicload64(&mstats.last_gc);
if(lastgc != 0 && unixnow - lastgc > forcegcperiod && runtime·atomicload(&runtime·forcegc.idle)) {
runtime·lock(&runtime·forcegc.lock);
if(runtime·forcegc.g != nil) {
// Goroutine may be started but has not initialized g yet.
runtime·forcegc.idle = 0;
runtime·forcegc.g->schedlink = nil;
injectglist(runtime·forcegc.g);
}
runtime·forcegc.idle = 0;
runtime·forcegc.g->schedlink = nil;
injectglist(runtime·forcegc.g);
runtime·unlock(&runtime·forcegc.lock);
}