mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmd/link: don't pass --build-id if C linker doesn't support it 

On Solaris the default (non-GNU) C linker doesn't support the
--build-id flag (and I'm not aware of any alternative). So check
that the linker supports the flag before passing it.

Updates #41004, #63934.

Cq-Include-Trybots: luci.golang.try:gotip-solaris-amd64
Change-Id: I4379e5bf6eb495154d663ac4ed802ecb11fcf91c
Reviewed-on: https://go-review.googlesource.com/c/go/+/621639
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Cherry Mui 2024-10-22 12:02:02 -04:00
parent c2b580a474
commit 15c5580160
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/link/elf_test.go
View File

@ -224,7 +224,9 @@ func TestGNUBuildID(t *testing.T) {
{"specific", "-B=0x0123456789abcdef", "\x01\x23\x45\x67\x89\xab\xcd\xef"}, {"specific", "-B=0x0123456789abcdef", "\x01\x23\x45\x67\x89\xab\xcd\xef"},
{"none", "-B=none", ""}, {"none", "-B=none", ""},
} }
if testenv.HasCGO() { if testenv.HasCGO() && runtime.GOOS != "solaris" && runtime.GOOS != "illumos" {
// Solaris ld doesn't support --build-id. So we don't
// add it in external linking mode.
for _, test := range tests { for _, test := range tests {
t1 := test t1 := test
t1.name += "_external" t1.name += "_external"

2
src/cmd/link/internal/ld/lib.go
View File

@ -1701,7 +1701,7 @@ func (ctxt *Link) hostlink() {
argv = append(argv, "-fuse-ld="+altLinker) argv = append(argv, "-fuse-ld="+altLinker)
} }
if ctxt.IsELF { if ctxt.IsELF && linkerFlagSupported(ctxt.Arch, argv[0], "", "-Wl,--build-id=0x1234567890abcdef") { // Solaris ld doesn't support --build-id.
if len(buildinfo) > 0 { if len(buildinfo) > 0 {
argv = append(argv, fmt.Sprintf("-Wl,--build-id=0x%x", buildinfo)) argv = append(argv, fmt.Sprintf("-Wl,--build-id=0x%x", buildinfo))
} else if *flagHostBuildid == "none" { } else if *flagHostBuildid == "none" {