From 12e620e8d675e97598d845b9a3888209c16dbdd3 Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Tue, 25 Feb 2020 14:50:01 -0500 Subject: [PATCH] go/ssa: disable recover2 testcase We still haven't figured out what's going on, but this is a low priority because the SSA interpreter isn't used by anyone. The primary concern is that this might be covering a legitimate underlying SSA bug. Updates golang/go#34089 Change-Id: I2886845b4f4b011104de945d04d6b8c4c436cbe9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/220957 Run-TryBot: Michael Matloob Reviewed-by: Heschi Kreinick --- go/ssa/interp/interp_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/go/ssa/interp/interp_test.go b/go/ssa/interp/interp_test.go index a216ac79f4..d2fe6d3e97 100644 --- a/go/ssa/interp/interp_test.go +++ b/go/ssa/interp/interp_test.go @@ -125,10 +125,10 @@ var testdataTests = []string{ } func run(t *testing.T, input string) bool { - // The recover2 test case is broken when run against tip. See golang/go#34089. - // TODO(matloob): Figure out what's going on or fix this before go1.14 is released. - if filepath.Base(input) == "recover2.go" && strings.HasPrefix(runtime.Version(), "devel") { - t.Skip("The recover2.go test is broken in tip. See golang.org/issue/34089.") + // The recover2 test case is broken on Go 1.14+. See golang/go#34089. + // TODO(matloob): Fix this. + if filepath.Base(input) == "recover2.go" { + t.Skip("The recover2.go test is broken in go1.14+. See golang.org/issue/34089.") } t.Logf("Input: %s\n", input)