From 120977040506794f00c74383289f913b1e0edd4a Mon Sep 17 00:00:00 2001 From: bronze1man Date: Mon, 14 Jan 2019 22:47:14 +0800 Subject: [PATCH] net/http: useless string replace operation in Cookie.String. Fixes #29135 --- src/net/http/cookie.go | 2 +- src/net/http/cookie_test.go | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/net/http/cookie.go b/src/net/http/cookie.go index 63f62214db..13ea3ce0c5 100644 --- a/src/net/http/cookie.go +++ b/src/net/http/cookie.go @@ -169,7 +169,7 @@ func (c *Cookie) String() string { return "" } var b strings.Builder - b.WriteString(sanitizeCookieName(c.Name)) + b.WriteString(c.Name) b.WriteRune('=') b.WriteString(sanitizeCookieValue(c.Value)) diff --git a/src/net/http/cookie_test.go b/src/net/http/cookie_test.go index 022adaa90d..4ac57cbe46 100644 --- a/src/net/http/cookie_test.go +++ b/src/net/http/cookie_test.go @@ -127,6 +127,14 @@ var writeSetCookiesTests = []struct { &Cookie{Name: "\t"}, ``, }, + { + &Cookie{Name: "\r"}, + ``, + }, + { + &Cookie{Name: "\n"}, + ``, + }, } func TestWriteSetCookies(t *testing.T) {