mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Address first round of code review comments

This commit is contained in:
James Fennell 2021-04-05 18:07:10 +00:00
parent d783b18706
commit 0e12fe3045
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/flag/flag.go
View File

@ -509,8 +509,7 @@ func UnquoteUsage(flag *Flag) (name string, usage string) {
func (f *FlagSet) PrintDefaults() {
f.VisitAll(func(flag *Flag) {
var b strings.Builder
b.WriteString(" -") // Two spaces before -; see next two comments.
b.WriteString(flag.Name)
fmt.Fprintf(&b, " -%s", flag.Name) // Two spaces before -; see next two comments.
name, usage := UnquoteUsage(flag)
if len(name) > 0 {
b.WriteString(" ")
@ -530,9 +529,9 @@ func (f *FlagSet) PrintDefaults() {
if !isZeroValue(flag, flag.DefValue) {
if _, ok := flag.Value.(*stringValue); ok {
// put quotes on the value
b.WriteString(fmt.Sprintf(" (default %q)", flag.DefValue))
fmt.Fprintf(&b, " (default %q)", flag.DefValue)
} else {
b.WriteString(fmt.Sprintf(" (default %v)", flag.DefValue))
fmt.Fprintf(&b, " (default %v)", flag.DefValue)
}
}
fmt.Fprint(f.Output(), b.String(), "\n")