mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

internal/copyright: skip testdata and vendor directories only 

Using filepath.SkipDir without confirming that d is a directory makes
it prone to taking unintended action if a file (not a directory) with
the same name gets added.

This isn't a problem today, but we shouldn't spend human code review
time checking that this doesn't somehow happen in the future, either.

Change-Id: I29bf203ddef175c3ad23c9ddc10fa934126ac853
Reviewed-on: https://go-review.googlesource.com/c/go/+/630635
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
This commit is contained in:
Dmitri Shuralyov 2024-11-21 12:50:14 -05:00 committed by Gopher Robot
parent dc8ceb63a8
commit 0db250104c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/internal/copyright/copyright_test.go
View File

@ -34,7 +34,7 @@ var permitted = [][]byte{
func TestCopyright(t *testing.T) {
buf := make([]byte, 2048)
filepath.WalkDir(filepath.Join(testenv.GOROOT(t), "src"), func(path string, d fs.DirEntry, err error) error {
if d.Name() == "testdata" || d.Name() == "vendor" {
if d.IsDir() && (d.Name() == "testdata" || d.Name() == "vendor") {
return filepath.SkipDir
}
switch filepath.Ext(d.Name()) {