mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

go/parser: avoid formatting a panic message if an assertion succeeds 

tryResolve is an extremely hot method on the parser. Eliminating this
formatting led to a 20% performance improvement in BenchmarkParse.

Change-Id: Idf8850404bd72d45d1351356427a85086422ea68
Reviewed-on: https://go-review.googlesource.com/c/go/+/302629
Trust: Robert Findley <rfindley@google.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Rob Findley 2021-03-17 12:42:19 -04:00 committed by Robert Findley
parent 70d54df4f6
commit 0bd308ff27
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/go/parser/parser.go
View File

@ -181,7 +181,10 @@ func (p *parser) tryResolve(x ast.Expr, collectUnresolved bool) {
if ident == nil { if ident == nil {
return return
} }
assert(ident.Obj == nil, fmt.Sprintf("identifier %s already declared or resolved", ident.Name)) // Don't use assert here, to avoid needless formatting of the message below.
if ident.Obj != nil {
panic(fmt.Sprintf("identifier %s already declared or resolved", ident.Name))
}
if ident.Name == "_" { if ident.Name == "_" {
return return
} }