mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

internal/trace: fix race condition in gc-stress 

Multiple goroutines all writing to the same sink triggers the race detector,
rightfully so.

Change-Id: Ia64836d0d88c0f587a6cb96ed747f656a3c1804a
Reviewed-on: https://go-review.googlesource.com/c/go/+/562997
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This commit is contained in:
Michael Pratt 2024-02-09 14:16:11 -05:00 committed by Gopher Robot
parent 9fa153b729
commit 09c62a86a9
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/internal/trace/v2/testdata/testprog/gc-stress.go vendored
View File

@ -39,7 +39,7 @@ func makeTree(depth int) *node {
var trees [16]*node var trees [16]*node
var ballast *[16]*[8192]*node var ballast *[16]*[8192]*node
var sink []byte var sink [][]byte
func main() { func main() {
for i := range trees { for i := range trees {
@ -54,10 +54,15 @@ func main() {
} }
} }
} }
for i := 0; i < runtime.GOMAXPROCS(-1); i++ {
procs := runtime.GOMAXPROCS(-1)
sink = make([][]byte, procs)
for i := 0; i < procs; i++ {
i := i
go func() { go func() {
for { for {
sink = make([]byte, rand.Intn(32<<10)) sink[i] = make([]byte, rand.Intn(32<<10))
} }
}() }()
} }