mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gopls/internal/regtest: only run in singleton mode 

singleton mode is naturally less flaky and faster than forwarded mode,
and provides 98% of the coverage.

Regtests have started to time-out in some particularly slow
environments.  Rather than not be able to write more regtests, let's
first run only in singleton mode by default.

I'll set up Kokoro CI to run in all modes.

Change-Id: I6b1c11b75f6c8fe002c123ab75b02f674e67e442
Reviewed-on: https://go-review.googlesource.com/c/tools/+/259137
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This commit is contained in:
Rob Findley 2020-10-02 09:57:41 -04:00 committed by Robert Findley
parent 22683886a9
commit 08f19738fa
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gopls/internal/regtest/runner.go
View File

@ -45,7 +45,7 @@ const (
SeparateProcess
// NormalModes are the global default execution modes, when unmodified by
// test flags or by individual test options.
NormalModes = Singleton | Forwarded
NormalModes = Singleton
)
// A Runner runs tests in gopls execution environments, as specified by its