From dc4eb74a5d83bc2900cc4cacc5a5739e2f13eb50 Mon Sep 17 00:00:00 2001 From: Zettat123 Date: Sun, 22 Jun 2025 09:39:35 -0600 Subject: [PATCH] Apply suggestions from code review Co-authored-by: wxiaoguang Signed-off-by: Zettat123 --- services/pull/commit_status.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/services/pull/commit_status.go b/services/pull/commit_status.go index a0c4085ebb..7952ca6fe3 100644 --- a/services/pull/commit_status.go +++ b/services/pull/commit_status.go @@ -47,9 +47,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*git_model.CommitStatus, requiredContextMatched = true } } - if !requiredContextMatched { - allRequiredContextsMatched = false - } + allRequiredContextsMatched = allRequiredContextsMatched && requiredContextMatched } if len(requiredCommitStatuses) == 0 { return commitstatus.CommitStatusPending