mirror of https://github.com/libsdl-org/SDL.git
video: Explicitly disallow setting the parent of a window to itself
Doing so causes a cycle in the window hierarchy tree graph, which leads to infinite recursion when destroying the windows.
This commit is contained in:
parent
c04624972e
commit
ca9b7c8ea3
|
|
@ -3672,6 +3672,10 @@ bool SDL_SetWindowParent(SDL_Window *window, SDL_Window *parent)
|
||||||
CHECK_WINDOW_NOT_POPUP(parent, false);
|
CHECK_WINDOW_NOT_POPUP(parent, false);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (window == parent) {
|
||||||
|
return SDL_SetError("Cannot set the parent of a window to itself.");
|
||||||
|
}
|
||||||
|
|
||||||
if (!_this->SetWindowParent) {
|
if (!_this->SetWindowParent) {
|
||||||
return SDL_Unsupported();
|
return SDL_Unsupported();
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue